Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add company level validation for accounting dimension #45302

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

Sugesh393
Copy link
Contributor

@Sugesh393 Sugesh393 commented Jan 17, 2025

Issue:
Accounting Dimension Validations are not happening as per Company

ref: 22387

Before:

company_validation_bfr.webm

After:

company_validation_af.webm

no-docs

@Sugesh393 Sugesh393 marked this pull request as ready for review January 21, 2025 12:26
@ruthra-kumar ruthra-kumar self-assigned this Jan 23, 2025
@ruthra-kumar ruthra-kumar removed the request for review from rohitwaghchaure January 23, 2025 10:25
@ruthra-kumar ruthra-kumar merged commit 49570a5 into frappe:develop Jan 27, 2025
13 checks passed
ruthra-kumar added a commit that referenced this pull request Jan 27, 2025
…-45302

feat: add company level validation for accounting dimension (backport #45302)
ruthra-kumar added a commit that referenced this pull request Jan 27, 2025
…-45302

feat: add company level validation for accounting dimension (backport #45302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants