Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update fields on change of item code In Update Items of Sales Order (backport #45125) #45557

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 28, 2025

Issue: Support Ticket - 28625

Depends on Frappe Fix : Currently, this.doc is not updating correctly after one update.
As Shown in screenshot on change of 3rd row this.doc contains value for last row that was added.
Screenshot 2025-01-07 at 11 38 15 AM

What This PR Does
This PR addresses the support issue of updating the rate and other fields if they are already set for the items, but due to a Frappe bug where doc.idx does not update correctly for multiple rows, the functionality currently works for a single row only. Once the Frappe fix is implemented, it will work perfectly for all rows.

Additionally, due to this same bug, the UOM update functionality, which is already written, is also not functioning correctly for multiple rows.


This is an automatic backport of pull request #45125 done by Mergify.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
… Order` (#45125)

* fix: update fields on change of item code

* fix: minor update

* fix: set the new values always

* Revert "fix: set the new values always"

This reverts commit 44daa0a.

---------

Co-authored-by: Sanket322 <shahsanket322003.com>
Co-authored-by: ruthra kumar <[email protected]>
(cherry picked from commit 9933d3c)
@ruthra-kumar ruthra-kumar merged commit 0576c5c into version-15-hotfix Jan 28, 2025
6 checks passed
@ruthra-kumar ruthra-kumar deleted the mergify/bp/version-15-hotfix/pr-45125 branch January 28, 2025 06:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants