-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle values passed via envvars #26
base: master
Are you sure you want to change the base?
Conversation
@fredrik-corneliusson Hi, thank you for this amazing library. I thought I could add an improvement there. Can you kindly give this a review? |
Thanks @tecoholic |
@fredrik-corneliusson Thank you for responding. I apologize for missing the contributing guidelines. I will test everything locally and update the PR. |
@@ -1,7 +1,7 @@ | |||
#!/usr/bin/env bash | |||
# Util command to run tests and code lint. | |||
|
|||
pytest && isort . && flake8 | |||
pytest && isort click_web tests && flake8 click_web tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check.sh
kept messing with the virutalenv files at .venv
. So I made it more explicit.
@fredrik-corneliusson I updated the changes to make sure tests aren't failing and added a couple of tests for the newly introduced changes as well. Kindly take another look when you have some time. |
Description
Click allows setting envvars to be used as a way to pass values to arguments and options. In such scenarios, the webui doesn't use the values from the environment it's run from.
In this PR, the default values in the forms are parsed and then overridden using the values from environment variables.