Fix unzip and add more unit tests. #16

frictionlessdata · Apr 19, 2018 · a6b1f88 · a6b1f88
1 parent f9932dd
commit a6b1f88
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/datapackage/package.go b/datapackage/package.go
@@ -301,7 +301,6 @@ func Load(path string, loaders ...validator.RegistryLoader) (*Package, error) {
 	if err != nil {
 		return nil, err
 	}
-	defer os.RemoveAll(dir)
 	fNames, err := unzip(path, dir)
 	if err != nil {
 		return nil, err

diff --git a/datapackage/package_test.go b/datapackage/package_test.go
@@ -494,7 +494,7 @@ func TestLoad(t *testing.T) {
 		// Writing a file which is in a subdir.
 		f1, err := w.Create("data/foo.csv")
 		is.NoErr(err)
-		_, err = f1.Write([]byte(`foo\nbar`))
+		_, err = f1.Write([]byte(`foo`))
 		is.NoErr(err)
 		is.NoErr(w.Close())
 
@@ -504,6 +504,9 @@ func TestLoad(t *testing.T) {
 		res := pkg.GetResource("res1")
 		is.Equal(res.name, "res1")
 		is.Equal(res.path, []string{"data/foo.csv"})
+		contents, err := res.ReadAll()
+		is.NoErr(err)
+		is.Equal(contents[0], []string{"foo"})
 	})
 	t.Run("Remote", func(t *testing.T) {
 		is := is.New(t)