Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs --> docsrc #786

Merged
merged 1 commit into from
Jun 28, 2017
Merged

docs --> docsrc #786

merged 1 commit into from
Jun 28, 2017

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Jun 28, 2017

Goodbye gh-pages - put docs directly in master tree

@forki
Copy link
Member

forki commented Jun 28, 2017

o_O is that a good idea?

@dsyme dsyme merged commit 74dd8fb into fsharp:master Jun 28, 2017
@dsyme
Copy link
Contributor Author

dsyme commented Jun 28, 2017

@forki I personally prefer it - but we can discuss

@dsyme
Copy link
Contributor Author

dsyme commented Jun 28, 2017

@forki Note this is the standard in ProjectScaffold now.

@forki
Copy link
Member

forki commented Jun 28, 2017

gh-pages is what github uses to display the docs. For us it's only a deployment target. You write the docs still in markdown in the docs folder

@forki
Copy link
Member

forki commented Jun 28, 2017

Note this is the standard in ProjectScaffold now.

o_O ?

@dsyme
Copy link
Contributor Author

dsyme commented Jun 28, 2017

@forki
Copy link
Member

forki commented Jun 28, 2017

why do you prefer it? we don't commit any artifacts?
and I assume this can lead to pretty nasty merge conflicts

@dsyme
Copy link
Contributor Author

dsyme commented Jun 28, 2017

why do you prefer it? we don't commit any artifacts?

Probably because I've had repeated trouble keeping gh-pages up-to-date. I've almost given up trying and the docs only get updated every 2-3 months as a result, or worse.

I know "build ReleaseDocs" is meant to do the job, but it has consistenly failed late for me - right after I've tagged, pushed nuget packages, everything, and then pushing the docs fails because of some password problem or something random. Then iterating on that is incredibly painful. With "docs", it's just part of the PR, like AssemblyInfo

But you're right this may just be pushing the pain elsewhere

and I assume this can lead to pretty nasty merge conflicts

Yes, possibly, you're right, especially for reference docs. Will keep an eye on it and move back to the old model if it is causing diff churn.

@forki
Copy link
Member

forki commented Jun 28, 2017

build ReleaseDocs was there for that. It allowed to update the docs at any point in time

@dsyme
Copy link
Contributor Author

dsyme commented Jun 28, 2017

build ReleaseDocs was there for that. It allowed to update the docs at any point in time

right, see above - it just kept failing late (during push) for too many obscure reasons I've also had a lot of trouble pushing to nuget.org from the build. Nearly always related to credentials. I hate credentials....

@forki
Copy link
Member

forki commented Jun 28, 2017

build ReleaseDocs doesn't use any credentials. it's just a git push
I'm a bit worried about that change in ProjectScaffold tbh

@dsyme
Copy link
Contributor Author

dsyme commented Jun 28, 2017

a bit worried about that change in ProjectScaffold tbh

Possibly it was a mistake. Open a ProjectScaffold issue asking what users think?

@forki
Copy link
Member

forki commented Jun 28, 2017

started it here: fsprojects/ProjectScaffold#304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants