EnumIdentable: Use member and extension expansions
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eRDe33
reviewed
Jan 28, 2025
| let enumError = Diagnostic(node: node._syntaxNode, message: Diagnostics.mustBeEnum) | ||
| context.diagnose(enumError) | ||
| return [] | ||
| public enum EnumIdentableMacro { |
There was a problem hiding this comment.
@ssestak Is there any reason for the original name Identable? I think it would be better to use the established Identifiable word, so EnumIdentifiableMacro.
What do you think guys? 🤔
There was a problem hiding this comment.
We had discussion about name before. I don't mind if we change it to EnumIdentifiableMacro. TBH for me it is one of the harder task to named something correctly 😅
@mikolasstuchlik what do you think ? I remember that I discussed it with you.
ssestak
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements
extensionbased expansion SE-0402.This change is source breaking, because previously required manual conformances will now get rejected (and/or won't emit the default implementation).
Closes #3 .