TESTS: add test for name clashing of globals in local() environments [#…

…608]

DESCRIPTION

@@ -1,5 +1,5 @@
 Package: future
-Version: 1.25.0-9013
+Version: 1.25.0-9014
 Title: Unified Parallel and Distributed Processing in R for Everyone
 Imports:
     digest,

NEWS

@@ -1,7 +1,7 @@
 Package: future
 ===============
 
-Version: 1.25.0-9013 [2022-05-07]
+Version: 1.25.0-9014 [2022-05-07]
 
 SIGNIFICANT CHANGES:
 

R/globals.R

@@ -101,6 +101,8 @@ getGlobalsAndPackages <- function(expr, envir = parent.frame(), tweak = tweakExp
       globals <- globalsOf(
                    ## Passed to globals::findGlobals()
                    expr, envir = envir, substitute = FALSE, tweak = tweak,
+                   ## Requires globals (>= 0.14.0.9004); ignored otherwise
+                   locals = getOption("future.globals.globalsOf.locals", FALSE),
                    ## Passed to globals::findGlobals() via '...'
                    dotdotdot = "return",
                    method = globals.method,

R/options.R

@@ -308,6 +308,9 @@ update_package_options <- function(debug = FALSE) {
   ## Prototyping in future 1.23.0:
   update_package_option("future.output.windows.reencode", mode = "logical", debug = debug)
 
+  ## Prototyping in future 1.26.0:
+  update_package_option("future.globals.globalsOf.locals", mode = "logical", debug = debug)
+
   ## SETTINGS USED FOR DEPRECATING FEATURES
   ## future 1.22.0:
   update_package_option("future.globals.keepWhere", mode = "logical", debug = debug)

tests/globals,locals.R

@@ -0,0 +1,43 @@
+source("incl/start.R")
+library("listenv")
+oopts <- c(oopts, options(
+  future.globals.resolve = TRUE,
+  future.globals.onMissing = "error"
+))
+
+okeep <- list()
+
+message("*** Globals inside local() environments ...")
+
+for (strategy in supportedStrategies()) {
+  message(sprintf("- plan('%s') ...", strategy))
+  plan(strategy)
+
+  ## Closures with local globals of the same name
+  g <- local({ a <- 1; function() a })
+  h <- local({ a <- 2; function() a })
+  truth <- h() + g()
+  print(truth)
+
+  ## Fixed in future (>= 1.25.0-9013) with globals (>= 0.14.0.9004)
+  ## Previously, 'a' of h() would overwrite 'a' of g(), resulting
+  ## in g() == 2, rather than g() == 1.
+  ## https://github.com/HenrikBengtsson/future/issues/608
+  if (is.null(getOption("future.globals.keepWhere")) && packageVersion("globals") >= "0.14.0.9004") {
+    okeep <- options(future.globals.keepWhere = TRUE)
+  }
+  f <- future(h() + g())
+  v <- value(f)
+  print(v)
+
+  if (!strategy %in% c("sequential", "multicore") || (packageVersion("globals") >= "0.14.0.9004") && getOption("future.globals.keepWhere", FALSE)) {
+    stopifnot(identical(v, truth))
+    options(okeep)
+  } else {
+    stopifnot(identical(v, h() + h()))
+  }
+} ## for (strategy ...)
+
+message("*** Globals inside local() environments ... DONE")
+
+source("incl/end.R")