-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [Feature] Modular stacks #205
Open
Christopher-Norman
wants to merge
10
commits into
develop
Choose a base branch
from
feature/modular-stacks
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [RPD-239] Improve the way the UI handles latency when contacting Azure services (#198) * [RPD-248] Add a basic example demonstrating how to use the API (#199) * updates docs * removes scratch.py * fixes typos * updates for comments * adds cli command to cli module * fix circular import (#201) * bumping to version v0.2.9 for release * adds tests --------- Co-authored-by: KirsoppJ <[email protected]> Co-authored-by: Jonathan Carlton <[email protected]>
* Add CLI stack add command * Update cli command with implementation and test cli command
…ding and removal of properties without overwriting (#207) * Add initial add/remove commands * Test remove property for MatchaConfigComponent * Fix docstring * Tests for MatchaConfigService * Update docstring with raises
* Migrate Terraform files to modules * Fix Seldon folder and add storage module to mlflow * Delete outputs.tf in Chroma module * Delete outputs.tf in Chroma/Chroma used for test * Remove ZenML ingress comments and move zenml namespace * Add variable VM size, remove testing default variables * Simplify precommit regex * Add vm size variable to aks module
* Add initial add function * Remove changes to stack remove command * Fix tests * Add core add method test * Add edge case tests and update stack name to custom on matcha stack add command * Use Typer for error handling and add test for existing state * Update to newer version of typer
* adds stack remove command * merges changes and finishes tests * updates logic and tests * fixes CI tests. * fixes CI * fixes CI * fixes CI * fixes CI * fixes CI
…ular Terraform files (#209) * Initial azure template updates * Add tests for new functions * Use print_error instead of print * Fix tests
* RPD-315 updated resource msg + made changes to get_stack() * RPD-315 removed old resource message constant variable * RPD-315 fixing 3.8 typing * RPD-315 fixing typing in the tests - missed on prev commit * RPD-315 fixing missed typing * RPD-315 updated tests based on failing CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces modular stacks. This allows users to customise the stack with 'modules' such as ZenML and MLflow with the ability to add and remove them easily before provisioning:
This also serves for the foundation of adding modules such as monitoring.
Checklist
Please ensure you have done the following:
Type of change
Tick all those that apply: