Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Feature] Modular stacks #205

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

Christopher-Norman
Copy link
Member

@Christopher-Norman Christopher-Norman commented Aug 24, 2023

This PR introduces modular stacks. This allows users to customise the stack with 'modules' such as ZenML and MLflow with the ability to add and remove them easily before provisioning:

matcha stack add ...
matcha stack remove

This also serves for the foundation of adding modules such as monitoring.

Checklist

Please ensure you have done the following:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation if required.
  • I have added tests which cover my changes.

Type of change

Tick all those that apply:

  • Bug Fix (non-breaking change, fixing an issue)
  • New feature (non-breaking change to add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

swells2020 and others added 2 commits August 24, 2023 10:07
* [RPD-239] Improve the way the UI handles latency when contacting Azure services (#198)

* [RPD-248] Add a basic example demonstrating how to use the API (#199)

* updates docs

* removes scratch.py

* fixes typos

* updates for comments

* adds cli command to cli module

* fix circular import (#201)

* bumping to version v0.2.9 for release

* adds tests

---------

Co-authored-by: KirsoppJ <[email protected]>
Co-authored-by: Jonathan Carlton <[email protected]>
* Add CLI stack add command

* Update cli command with implementation and test cli command
@Christopher-Norman Christopher-Norman self-assigned this Aug 24, 2023
@Christopher-Norman Christopher-Norman changed the base branch from develop to main August 24, 2023 09:22
@Christopher-Norman Christopher-Norman changed the base branch from main to develop August 24, 2023 09:23
Christopher-Norman and others added 8 commits August 24, 2023 11:44
…ding and removal of properties without overwriting (#207)

* Add initial add/remove commands

* Test remove property for MatchaConfigComponent

* Fix docstring

* Tests for MatchaConfigService

* Update docstring with raises
* Migrate Terraform files to modules

* Fix Seldon folder and add storage module to mlflow

* Delete outputs.tf in Chroma module

* Delete outputs.tf in Chroma/Chroma used for test

* Remove ZenML ingress comments and move zenml namespace

* Add variable VM size, remove testing default variables

* Simplify precommit regex

* Add vm size variable to aks module
* Add initial add function

* Remove changes to stack remove command

* Fix tests

* Add core add method test

* Add edge case tests and update stack name to custom on matcha stack add command

* Use Typer for error handling and add test for existing state

* Update to newer version of typer
* adds stack remove command

* merges changes and finishes tests

* updates logic and tests

* fixes CI tests.

* fixes CI

* fixes CI

* fixes CI

* fixes CI

* fixes CI
…ular Terraform files (#209)

* Initial azure template updates

* Add tests for new functions

* Use print_error instead of print

* Fix tests
* RPD-315 updated resource msg + made changes to get_stack()

* RPD-315 removed old resource message constant variable

* RPD-315 fixing 3.8 typing

* RPD-315 fixing typing in the tests - missed on prev commit

* RPD-315 fixing missed typing

* RPD-315 updated tests based on failing CI
@Christopher-Norman Christopher-Norman added the enhancement New feature or request label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants