Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPD-308] Add stack module validation #206

Conversation

Christopher-Norman
Copy link
Member

@Christopher-Norman Christopher-Norman commented Aug 24, 2023

This PR adds an ENUM for existing stack modules and adds a validation function to allow checking of adding/removing modules.

Checklist

Please ensure you have done the following:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation if required.
  • I have added tests which cover my changes.

Type of change

Tick all those that apply:

  • Bug Fix (non-breaking change, fixing an issue)
  • New feature (non-breaking change to add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@Christopher-Norman Christopher-Norman added the enhancement New feature or request label Aug 24, 2023
@Christopher-Norman Christopher-Norman self-assigned this Aug 24, 2023
@Christopher-Norman Christopher-Norman changed the base branch from develop to feature/modular-stacks August 24, 2023 10:23
Copy link
Contributor

@swells2020 swells2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧦

@Christopher-Norman Christopher-Norman merged commit 6722ba6 into feature/modular-stacks Aug 24, 2023
@Christopher-Norman Christopher-Norman deleted the RRPD-308-add-stack-module-validation branch August 24, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants