-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added custom binding 'DisableableBinding' and added it to README.md. #46
Open
Solander
wants to merge
4
commits into
fyne-io:master
Choose a base branch
from
Solander:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
522ee60
"Added custom binding 'DisableableBinding' and added it to README.md."
Solander ba137c2
"Substituted the name 'targets' for 'widgets' consistantly throughout…
Solander a3744b3
"NewDisableableBinding now returns an interface."
Solander cd41cfd
"Added test for DisableableBinding."
Solander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
package binding | ||
|
||
import ( | ||
"log" | ||
|
||
"fyne.io/fyne/v2" | ||
"fyne.io/fyne/v2/data/binding" | ||
) | ||
|
||
type disableableBinding struct { | ||
binding.Bool | ||
|
||
inverted bool | ||
targets []fyne.Disableable | ||
} | ||
|
||
// NewDisableableBinding returns a `Bool` binding which accepts Disableable targets. | ||
// When the Bool changes, the targets Enable or Disable method will be executed. | ||
func NewDisableableBinding(targets ...fyne.Disableable) *disableableBinding { | ||
newBinding := &disableableBinding{ | ||
Bool: binding.NewBool(), | ||
targets: targets, | ||
} | ||
|
||
// Add default listener | ||
newBinding.AddListener(binding.NewDataListener(newBinding.update)) | ||
|
||
return newBinding | ||
} | ||
|
||
// Adding targets to the binding. | ||
// This will update the Disable status of the targets immediately. | ||
func (b *disableableBinding) AddTargets(targets ...fyne.Disableable) { | ||
b.targets = append(b.targets, targets...) | ||
b.update() | ||
} | ||
|
||
// Invert will switch the behavior of when the targets will be Enabled or Disabled. | ||
// This will update the Disable status of the targets immediately. | ||
func (b *disableableBinding) Invert(inverted bool) { | ||
b.inverted = inverted | ||
b.update() | ||
} | ||
|
||
func (b *disableableBinding) update() { | ||
val, err := b.Get() | ||
if err != nil { | ||
log.Println(err) | ||
return | ||
} | ||
|
||
if (!b.inverted && val) || (b.inverted && !val) { | ||
for _, target := range b.targets { | ||
target.Enable() | ||
} | ||
} else { | ||
for _, target := range b.targets { | ||
target.Disable() | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be
SetInverted
? The nameInvert
applies action, which is to take something and make it the opposite state - which isn't really what the method does...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea with SetInverted. I had it as an action first, but then realized that it wasn't a good solution so I changed it. I'll change the name.
Isn't Widgets to generalized since it's only widgets that implements Disableable that are accepted? I agree that "targets" isn't a good name either. I guess "disableableWidgets" too long?
Not really sure what similar scenarios there are in Fyne and how they are named.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Go we don't typically put the type in the naming do we? For example
Form.AddItem
takes awidget.FormItem
etc.So the type ensures safety and the "Disablable" context is kindof provided by the object you are working with.
Happy to get others thoughts of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed the name to Widget and also a SetInverted.
Do you feel that this issue is resolved or was there something more about name?
I've been thinking about maybe changing the name of the binding. Fells a bit to much to say binding.DisableableBinding.
Either change the name to Disableable or DisableableBool.
Any opinions on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you it could have a smoother name.
binding.NewDisableable
is a pretty good suggestion.Apologies for the delay