Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove call to Refresh() inside fileItemRenderer.Layout() #4302

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Remove call to Refresh() inside fileItemRenderer.Layout() #4302

merged 1 commit into from
Oct 7, 2023

Conversation

JordanGoulder
Copy link
Contributor

Description:

Calling Refresh() on the item label inside fileItemRenerer.Layout() causes a crash due to a race condition where Layout and Refresh occur at the same time.

Fixes #4260

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 65.074% (+0.002%) from 65.072% when pulling ed8985d on JordanGoulder:fix_fileitem_crash into d530122 on fyne-io:develop.

@dweymouth dweymouth merged commit 15222ef into fyne-io:develop Oct 7, 2023
10 of 11 checks passed
@JordanGoulder JordanGoulder deleted the fix_fileitem_crash branch October 8, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweymouth dweymouth dweymouth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JordanGoulder @coveralls @dweymouth