-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding triple tap to select current row for widget.Entry #4337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to have this addition - but I wonder if we can avoid duplicating constants?
Looks like there's still an import cycle in test code. I'll take a look in a bit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wonderful. What a difference in usability! Thanks :D
Just left one comment on the placement of the consts :)
I wonder, should we expose an interface for making a widget triple tappable instead of exposing the double tap delay? |
We figured that Entry was probably the only widget that needed triple tap. Also personally I'd like the double tap delay to be exposed since I have my list rows in Supersonic implement their own double tap logic (here - so that tap can instantly trigger to select the row of a tracklist while double tap can play a track). Having a widget have both Tappable and DoubleTappable means, by design, it won't get the tap event until after the delay, which is not what I wanted in my case. Edit: either that - or a way to request for a specific widget that the Tapped callback should be invoked immediately even if it may become a DoubleTap if tapped again |
This is tough to be convinced of - as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks to be in a good place now :)
Description:
Fixes #4328
Checklist:
Where applicable: