Fix race in window fullscreen test

[andydotxyz]

Checklist:

• Tests included.
• Lint and formatter run with no errors.
• Tests all pass.

[Jacalz]

It seems like you are passing in a "false" parameter into almost all uses of the function. Would another solution not be better?

[andydotxyz]

I'm not sure what other solution you have in mind.
This helper function was doing too much in one block so either we pass in this extra state or it has to split into separate functions and all the tests have more code than before?

[Jacalz]

If I counted correctly, you are only passing in true in one of the tests. That just makes me think that the parameter shouldn't be there and that that one test needs to be modified, not all the other.

[andydotxyz]

If I counted correctly, you are only passing in true in one of the tests. That just makes me think that the parameter shouldn't be there and that that one test needs to be modified, not all the other.

I understand. Updated.

[andydotxyz]

I guess the tests don't agree - for some reason that kicked me back to square one.
Off to think more.

[andydotxyz]

Merging in with the requested change to get this release together

[Jacalz]

Off to think more.

I read this as you wanting to work on this more and hence did not review. Sorry if I misunderstood.

[andydotxyz]

Not a problem. I think the items on GitHub appeared out of order for some reason. The commit above was the result of the thinking.