-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance functionality of InnerWindow #5305
Conversation
Would it make sense to default to buttons on the right side on Windows and Linux? Windows seems like a rather simple choice but Linux has more customisation of course. However, with all the major Linux vendors distributions like Ubuntu and Fedora defaulting to the right side it seems like a sensible choice? |
that should do it |
Would it be OK to re-use the existing button align consts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nice addition, thanks
All new APIs need the:
//
// Since: 2.6
lines at the end of their documentation
For the record: I realised that my comment about Fedora defaulting to buttons on the right side is technically incorrect, at least on Gnome. Anyhow, Ubuntu is the largest and they default to the right like most other :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Some minor comments inline :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I realised that I missed some things in my last review
Hi @roffe, it's not clear why this was deleted, was it a mistake? |
Description:
2 changes:
First:
allow customization of button location on InnerWindow via InnerWindow.ButtonAlignment
The widget.ButtonAlign constant is used to configure
Second
Added
Title() string
function to retrieve the title of the current inner window