Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a tab is asked to refresh just pass that to the button #5312

Merged
merged 1 commit into from
Dec 11, 2024
Merged

When a tab is asked to refresh just pass that to the button #5312

merged 1 commit into from
Dec 11, 2024

Conversation

andydotxyz
Copy link
Member

Fixes #5310

Checklist:

  • Tests included. <- it's in the render refresh logic of draw so all state was correct
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 60.015% (+0.008%) from 60.007%
when pulling 55a2746 on andydotxyz:fix/5310
into c89253d on fyne-io:release/v2.5.x.

Jacalz
Jacalz approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks

@andydotxyz andydotxyz merged commit 7b93933 into fyne-io:release/v2.5.x Dec 11, 2024
12 checks passed
@andydotxyz andydotxyz deleted the fix/5310 branch December 11, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andydotxyz @coveralls @Jacalz