Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the negative offsets in viewport that Google started using #5315

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Handle the negative offsets in viewport that Google started using #5315

merged 1 commit into from
Dec 18, 2024

Conversation

andydotxyz
Copy link
Member

Fixes #5313

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 59.952% (-0.002%) from 59.954%
when pulling f5a64ef on andydotxyz:fix/5313
into 5ee9979 on fyne-io:develop.

dweymouth
dweymouth approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@dweymouth dweymouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from a code quality perspective. I'll trust that you've done the local testing that I have not :)

@andydotxyz andydotxyz merged commit 0685580 into fyne-io:develop Dec 18, 2024
12 checks passed
@andydotxyz andydotxyz deleted the fix/5313 branch December 18, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweymouth dweymouth dweymouth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andydotxyz @coveralls @dweymouth