-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix HiDPI issue #161
fix HiDPI issue #161
Conversation
burner-account
commented
Jan 18, 2020
- as of HiDPI broken, possible workaround inside #159
- switch to glfw 3.3
- retrieving scale via (*glfw.Window).GetContentScale()
- scaling mouse positions accordingly
If this one is accepted, you will need to patch the g3nd raycasting demo to obey UI scaling.
|
// GlfwWindow describes one glfw window | ||
|
||
// GlfwWindow describes one glfw window | ||
type GlfwWindow struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the extra lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lack of coffee... definitly not intention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tentative approval from me.
Thanks @burner-account and @wolfgarnet. There have been a lot of changes since this was created, so I'll close it.
Did it have an impact in fixing HDPI? |
Quite frankly, i do not remember. Might have been only relevant to my system setup without me knowing it. "ScaleToMonitor - Specifies whether the window content area should be resized based on the monitor current scale of any monitor it is placed on. This includes the initial placement when the window is created." From my current point of view this should be something configurable in the product using g3n/engine. |