Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #301, race detector will failed with g3n #302

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Fix #301, race detector will failed with g3n #302

merged 1 commit into from
Dec 22, 2023

Conversation

zyxkad
Copy link
Contributor

@zyxkad zyxkad commented Dec 20, 2023 •
edited
Loading

Now we convert uint32 into C.GLsizeiptr first, then convert GLsizeiptr into *void inside C function, so the race detector will not failed anymore.

@zyxkad zyxkad marked this pull request as draft December 20, 2023 02:46
@zyxkad
fix g3n#301
67da003 
Now we convert uint32 into C.GLsizeiptr first, then convert GLsizeiptr into *void inside C function, so the race detector will not failed anymore.
@zyxkad zyxkad marked this pull request as ready for review December 20, 2023 02:47
@danaugrs danaugrs merged commit 721b746 into g3n:master Dec 22, 2023
@danaugrs
Copy link
Member

Thanks for the fixes!!

xackery pushed a commit to xackery/engine that referenced this pull request Feb 28, 2024
@zyxkad @xackery
fix g3n#301 (g3n#302)
958389a 
Now we convert uint32 into C.GLsizeiptr first, then convert GLsizeiptr into *void inside C function, so the race detector will not failed anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fatal error: checkptr: pointer arithmetic computed bad pointer value on GLS.VertexAttribPointer
2 participants
@zyxkad @danaugrs