Use docker-compose for Github CI workflow #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's bugging me that we now have both a docker-compose.yml and an `integration-tests` section in ci.yaml. The two are identical, but different syntax. I've updated the Github workflow to use `docker compose` instead of duplicating the service logic.
criccomini
force-pushed
the
docker-compose-for-ci
branch
from
f26e4b8 to
cb66e2f
Compare
|
cc @mjperrone FYI ^ |
mjperrone
reviewed
Jan 27, 2024
| @@ -166,25 +85,33 @@ jobs: | |||
| run: | | |||
| pdm run integration | |||
|
|
|||
| - name: Docker Compose Down | |||
There was a problem hiding this comment.
How does this call down? it looks identical to the up block
There was a problem hiding this comment.
Mmm.. good point. Too much cargoculting from GPT4. :P Lemme fix..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's bugging me that we now have both a docker-compose.yml and an
integration-testssection in ci.yaml. The two are identical, but different syntax. I've updated the Github workflow to usedocker composeinstead of duplicating the service logic.