Merge pull request #323 from gacela-project/fix/better-php84-support-2

Better PHP 8.4 support
gacela-project · Dec 12, 2024 · c2e757b · c2e757b
2 parents 9391a1d + 62cb6d9
commit c2e757b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## [1.9.1](https://github.com/gacela-project/gacela/compare/1.9.0...1.9.1) - 2024-12-12
+
+- Better compatibility with PHP 8.4
+
 ## [1.9.0](https://github.com/gacela-project/gacela/compare/1.8.1...1.9.0) - 2024-12-01
 
 - Compatibility with PHP 8.4

diff --git a/tests/Feature/Framework/ListeningEvents/ClassResolver/DisableListenersTest.php b/tests/Feature/Framework/ListeningEvents/ClassResolver/DisableListenersTest.php
@@ -8,13 +8,11 @@
 use Gacela\Framework\Gacela;
 use GacelaTest\Feature\Framework\ListeningEvents\ClassResolver\Module\Facade;
 use PHPUnit\Framework\Attributes\PreserveGlobalState;
-use PHPUnit\Framework\Attributes\RunInSeparateProcess;
 use PHPUnit\Framework\TestCase;
 use RuntimeException;
 
 final class DisableListenersTest extends TestCase
 {
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
     public function test_disable_class_resolver_listener(): void
     {

diff --git a/tests/Feature/Framework/StaticFacade/FeatureTest.php b/tests/Feature/Framework/StaticFacade/FeatureTest.php
@@ -10,7 +10,6 @@
 use GacelaTest\Feature\Framework\StaticFacade\ModuleB\Facade as TestObjectFacade;
 use GacelaTest\Feature\Framework\StaticFacade\ModuleB\Factory as ObjectFactory;
 use PHPUnit\Framework\Attributes\PreserveGlobalState;
-use PHPUnit\Framework\Attributes\RunInSeparateProcess;
 use PHPUnit\Framework\TestCase;
 
 final class FeatureTest extends TestCase
@@ -20,7 +19,6 @@ protected function setUp(): void
         Gacela::bootstrap(__DIR__);
     }
 
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
     public function test_unknown_static_facade_method(): void
     {
@@ -29,7 +27,6 @@ public function test_unknown_static_facade_method(): void
         TestStaticFacade::unknown();
     }
 
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
     public function test_unknown_object_factory_method(): void
     {
@@ -38,7 +35,6 @@ public function test_unknown_object_factory_method(): void
         (new TestObjectFacade())->unknown();
     }
 
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
     public function test_unknown_static_factory_method(): void
     {
@@ -47,7 +43,6 @@ public function test_unknown_static_factory_method(): void
         TestStaticFacade::unknownFacadeMethod();
     }
 
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
     public function test_module_a_static_facade(): void
     {
@@ -56,7 +51,6 @@ public function test_module_a_static_facade(): void
         self::assertSame(StaticFactory::STR, $actual);
     }
 
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
     public function test_module_a_object_facade(): void
     {
@@ -65,7 +59,6 @@ public function test_module_a_object_facade(): void
         self::assertSame(ObjectFactory::STR, $actual);
     }
 
-    #[RunInSeparateProcess]
     #[PreserveGlobalState(false)]
     public function test_factory_static_facade_method(): void
     {

diff --git a/...s/Integration/Framework/DocBlockResolverAware/DocBlockResolverCustomServicesAwareTest.php b/...s/Integration/Framework/DocBlockResolverAware/DocBlockResolverCustomServicesAwareTest.php
@@ -26,6 +26,7 @@ protected function setUp(): void
     {
         Gacela::bootstrap(__DIR__, static function (GacelaConfig $config): void {
             $config->resetInMemoryCache();
+            $config->enableFileCache(__DIR__);
             $config->addAppConfigKeyValue(GacelaFileCache::KEY_ENABLED, true);
             $config->registerGenericListener(static function (GacelaEventInterface $event): void {
                 // dump('Triggered -> ' . \get_class($event)); # useful for debugging