Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config can now live outside the repository #10

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

gaelicWizard
Copy link
Owner

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard force-pushed the dev branch 6 times, most recently from 6195bb1 to 53a9e90 Compare January 9, 2022 07:56
@gaelicWizard gaelicWizard force-pushed the dev branch 4 times, most recently from 01fecb2 to c241d32 Compare January 12, 2022 22:27
@@ -19,7 +19,7 @@ case $OSTYPE in
;;
esac

if [ ! -z "$(command ls "${BASH_IT}/enabled/"{[0-9][0-9][0-9]${BASH_IT_LOAD_PRIORITY_SEPARATOR}docker,docker}.plugin.bash 2>/dev/null | head -1)" ]; then
if [ ! -z "$(command ls "${BASH_IT_CONFIG}/enabled/"{[0-9][0-9][0-9]${BASH_IT_LOAD_PRIORITY_SEPARATOR}docker,docker}.plugin.bash 2>/dev/null | head -1)" ]; then
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if [ ! -z "$(command ls "${BASH_IT_CONFIG}/enabled/"{[0-9][0-9][0-9]${BASH_IT_LOAD_PRIORITY_SEPARATOR}docker,docker}.plugin.bash 2>/dev/null | head -1)" ]; then
if _bash-it-component-item-is-enabled plugin docker; then

@gaelicWizard gaelicWizard force-pushed the dev branch 3 times, most recently from 7df4f28 to 4fb3a7c Compare January 25, 2022 22:27
@gaelicWizard gaelicWizard force-pushed the dev branch 5 times, most recently from 1875fd7 to 73f36ff Compare February 1, 2022 23:27
@gaelicWizard gaelicWizard force-pushed the dev branch 3 times, most recently from acd8525 to a3ae4cb Compare February 9, 2022 05:06
@gaelicWizard gaelicWizard force-pushed the dev branch 4 times, most recently from 8fd8f6a to 06862e3 Compare February 20, 2022 20:35
@gaelicWizard gaelicWizard force-pushed the dev branch 3 times, most recently from 876dde1 to 74b343f Compare March 4, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants