Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessions Check misuse the response's success key #23

Open
loicteixeira opened this issue Aug 13, 2017 · 0 comments
Open

Sessions Check misuse the response's success key #23

loicteixeira opened this issue Aug 13, 2017 · 0 comments

Comments

@loicteixeira
Copy link

When using Sessions Check, it will return {"success":true} when a session is open but {"success":false,"message":""} when there is no open session.

The success key should only be used to indicate whether the request succeeded or failed (like any other API call).

The result of the check should has its own key, e.g. check or has_session_open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant