SC Gardener aws-ebs-csi-driver image update #1080
Conversation
|
|
gardener-robot
added
area/control-plane
|
@scs-gardener-team-gitlab Thank you for your contribution. |
gardener-robot
added
the
size/xs
|
Thank you @scs-gardener-team-gitlab for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
|
Additional Links:
|
|
The PR does not really enable the XFS option though does it ? From a user's perspective, how can he enable the new Helm chart option if it's not exposed via the shoot spec (e.g. controlplaneConfig) |
|
lgtm. Let's merge this PR first though. |
|
Hi @kon-angelo and @hebelsan , Are we ready to proceed with merging this PR? |
| if value, ok := cluster.Shoot.Annotations[aws.legacyXFS]; ok { | ||
| csiDriverNodeValues["driver"] = map[string]interface{}{ | ||
| "legacyXFS": value, | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
With the code as it is, you would overwrite the value of VolumeAttachLimit in the driver key of the map. You should only create the map if it's not there.
| @@ -48,6 +48,9 @@ spec: | |||
| {{- if .Values.driver.volumeAttachLimit }} | |||
| - --volume-attach-limit={{ .Values.driver.volumeAttachLimit }} | |||
| {{- end }} | |||
| {{- if .Values.driver.legacyXFS }} | |||
| - --legacyXFS={{ .Values.driver.legacyXFS }} | |||
There was a problem hiding this comment.
Also this flag is not even correct. https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/7fd319a43ee6fe339517051226c506304d3f5f94/pkg/driver/options.go#L120 is the proper format.
kon-angelo
force-pushed
the
sc-gardener-csi-driver-update
branch
from
eb405d7 to
79baeb7
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
How to categorize this PR?
/area storage
/area control-plane
/area delivery
/kind bug
/platform aws
What this PR does / why we need it:
SC Gardener landscapes require the aws csi-driver to run in legacyXFS mode. To do this the parameter needs to be configurable inside of the values.yaml file as well as added to the daemonset if aforementioned parameter is set to
True.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Test manually. Paused the corresponding managed resource object, edited the csi-driver pod and its image for one of our cluster to use the
1.35.0version. Then, edited the pod spec to include the extra legacyXFS patameter. The pod is running fine with no issues in legacyXFS mode.Release note: