Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML Intro #9

Merged
merged 5 commits into from
Mar 2, 2020
Merged

HTML Intro #9

merged 5 commits into from
Mar 2, 2020

Conversation

yosefanajjar
Copy link
Member

@yosefanajjar yosefanajjar commented Feb 25, 2020 •
edited
Loading

hshahwan
hshahwan previously approved these changes Feb 25, 2020
View reviewed changes
mghada
mghada requested changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@mghada mghada left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yosefanajjar Please see Mohammed's notes

@hshahwan
Copy link
Collaborator

hshahwan commented Mar 1, 2020

@yosefanajjar intro HTML5 is the first session right?
so make sure to update the file structure and add this files in session-1

Good work 👍

hshahwan
hshahwan previously approved these changes Mar 1, 2020
View reviewed changes
Salam-Dalloul
Salam-Dalloul previously approved these changes Mar 2, 2020
View reviewed changes
MohammedYehia
MohammedYehia requested changes Mar 2, 2020
View reviewed changes
coursebook/session-01/elements-and-attributes.md Outdated

**Example**

```html=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the equal sign "=" from this and this applies to the rest of the code so please remove this from all of them

something like this "```html"

@yosefanajjar yosefanajjar dismissed stale reviews from Salam-Dalloul and hshahwan via 833fec9 March 2, 2020 09:53
@hshahwan hshahwan merged commit 0aae259 into master Mar 2, 2020
@hshahwan hshahwan deleted the html-intro branch March 2, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hshahwan hshahwan hshahwan approved these changes

@Salam-Dalloul Salam-Dalloul Salam-Dalloul approved these changes

@mghada mghada Awaiting requested review from mghada

@MohammedYehia MohammedYehia Awaiting requested review from MohammedYehia

Assignees

@Salam-Dalloul Salam-Dalloul

@hshahwan hshahwan

Labels
awaiting-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yosefanajjar @hshahwan @MohammedYehia @Salam-Dalloul @mghada