Skip to content

Commit

Permalink
Depend on ignition-utils1 cli component (#55)
Browse files Browse the repository at this point in the history
* Use SuppressWarning.hh from ignition-utils

Use the headers from ignition/utils instead of ignition/utilities.
This also exports the dependency on ignition-utils1::ignition-utils1
instead of ignition-cmake2::utilities.

* rm configure.bat
* Add libignition-tools-dev to tutorial

Signed-off-by: Steve Peters <[email protected]>
  • Loading branch information
scpeters authored Aug 9, 2021
1 parent 87b2b3b commit 91c3e64
Show file tree
Hide file tree
Showing 10 changed files with 14 additions and 32 deletions.
1 change: 1 addition & 0 deletions .github/ci/packages.apt
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
libignition-cmake2-dev
libignition-tools-dev
libignition-utils1-cli-dev
6 changes: 6 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ ign_find_package(DL
ign_find_package(ignition-tools QUIET)


#--------------------------------------
# Find ignition-utils
ign_find_package(ignition-utils1 REQUIRED COMPONENTS cli)
set(IGN_UTILS_VER ${ignition-utils1_VERSION_MAJOR})


#============================================================================
# Configure the build
#============================================================================
Expand Down
25 changes: 0 additions & 25 deletions configure.bat

This file was deleted.

2 changes: 1 addition & 1 deletion core/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ ign_create_core_library(
CXX_STANDARD 17)

target_link_libraries(${PROJECT_LIBRARY_TARGET_NAME}
PUBLIC ignition-cmake${IGN_CMAKE_VER}::utilities)
PUBLIC ignition-utils${IGN_UTILS_VER}::ignition-utils${IGN_UTILS_VER})

# Build the unit tests
ign_build_tests(
Expand Down
2 changes: 1 addition & 1 deletion core/include/ignition/plugin/Info.hh
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
#include <string>
#include <unordered_map>

#include <ignition/utilities/SuppressWarning.hh>
#include <ignition/utils/SuppressWarning.hh>

#include <ignition/plugin/Export.hh>

Expand Down
2 changes: 1 addition & 1 deletion core/include/ignition/plugin/Plugin.hh
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#include <map>
#include <string>

#include <ignition/utilities/SuppressWarning.hh>
#include <ignition/utils/SuppressWarning.hh>

#include <ignition/plugin/Export.hh>
#include <ignition/plugin/Info.hh>
Expand Down
2 changes: 1 addition & 1 deletion core/include/ignition/plugin/detail/Factory.hh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#include <memory>
#include <utility>

#include <ignition/utilities/SuppressWarning.hh>
#include <ignition/utils/SuppressWarning.hh>

#include <ignition/plugin/Factory.hh>

Expand Down
2 changes: 1 addition & 1 deletion loader/include/ignition/plugin/Loader.hh
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
#include <typeinfo>
#include <unordered_set>

#include <ignition/utilities/SuppressWarning.hh>
#include <ignition/utils/SuppressWarning.hh>

#include <ignition/plugin/loader/Export.hh>
#include <ignition/plugin/PluginPtr.hh>
Expand Down
2 changes: 1 addition & 1 deletion register/include/ignition/plugin/detail/Register.hh
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
#include <type_traits>
#include <utility>

#include <ignition/utilities/SuppressWarning.hh>
#include <ignition/utils/SuppressWarning.hh>

#include <ignition/plugin/EnablePluginFromThis.hh>
#include <ignition/plugin/Info.hh>
Expand Down
2 changes: 1 addition & 1 deletion tutorials/02_installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ sudo apt install libignition-plugin-dev

1. Install Ignition dependencies
```
sudo apt-get install libignition-cmake2-dev
sudo apt-get install libignition-cmake2-dev libignition-tools-dev libignition-utils1-cli-dev
```

2. Clone the repository
Expand Down

0 comments on commit 91c3e64

Please sign in to comment.