Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set window to dummy object if not defined #78

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

bakkdoor
Copy link
Contributor

@bakkdoor bakkdoor commented Apr 1, 2017

This fixes an error when using elm-ui with rtfeldman/elm-css.
Similar to e778f0a

This fixes an error when using elm-ui with rtfeldman/elm-css.
Similar to e778f0a
@bakkdoor
Copy link
Contributor Author

bakkdoor commented Apr 1, 2017

A 1.2.2 release upon merge would be appreciated :)
Related to #77

@bakkdoor
Copy link
Contributor Author

bakkdoor commented Apr 1, 2017

I ran into this after trying to use the Ui.Input component.

@bakkdoor
Copy link
Contributor Author

bakkdoor commented Apr 1, 2017

Not sure what the best way is to fix that CI failure. Looks like it can't find XMLHttpRequest now for some reason 😞

bakkdoor added a commit to syncrypt/desktop that referenced this pull request Apr 6, 2017
This is to fix compilation issues with elm-css.
Related to gdotdesign/elm-ui#78
@fosskers
Copy link

This happens when importing certain modules, but not all. I use emacs's elm-mode, and importing Chooser or NotificationCenter gives me:

> import Day1 exposing (..)
/home/colin/code/horizon/aafa/ui/repl-temp-000.js:5916
    var styles = window.getComputedStyle(document.documentElement, '');
                 ^

ReferenceError: window is not defined
    at /home/colin/code/horizon/aafa/ui/repl-temp-000.js:5916:18
    at Object.<anonymous> (/home/colin/code/horizon/aafa/ui/repl-temp-000.js:5924:2)
    at Object.<anonymous> (/home/colin/code/horizon/aafa/ui/repl-temp-000.js:15243:4)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.runMain (module.js:605:10)
    at run (bootstrap_node.js:423:7)

when I try to recompile my code in my embedded repl.

@gdotdesign
Copy link
Owner

This commit f983acf should fix the original issue, I'm not sure if would fix elm-mode errors.

This is to allow using latest style-elements library version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants