Skip to content

Commit

Permalink
sys-apps/coreutils-9.5: version bump, add Solaris fix
Browse files Browse the repository at this point in the history
Signed-off-by: Fabian Groffen <[email protected]>
  • Loading branch information
grobian committed Jul 26, 2024
1 parent a39343a commit af61f0a
Show file tree
Hide file tree
Showing 3 changed files with 365 additions and 0 deletions.
3 changes: 3 additions & 0 deletions sys-apps/coreutils/Manifest
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,6 @@ DIST coreutils-9.1.tar.xz 5712104 BLAKE2B f5654e4935535275615d44a56c071d1c0746af
DIST coreutils-9.1.tar.xz.sig 833 BLAKE2B e9627a066f3c67596feaa8d43d5785076230f440bacea84d8b5736e51a22787c2d5df1f3e2cd8523d01fb7b468933d3c17fce3cb1fbefef322a0e0d820b81842 SHA512 9f0766531afd4faa3e2c337730f61db55605cf06729e9c61f644594883732c2e0b1ddb0005b492be309c53e6f45b8ff875398163a48699d52517ea49e9bdbc91
DIST coreutils-9.3.tar.xz 5808696 BLAKE2B 11502cd2dbeef150d0d4cece2546bf6b835941b94456c258f6058338f0477f22e68e88934d075b08fe51ee4d1c0c50cb23d8084ac06a457d6e8975f01643b1cd SHA512 242271f212a6860bdc6c8d7e5c4f85ce66c1b48ef781aca9daa56e0fe7c2b7809ef72b4392120219fe5b687637c83ce89ceef8bb35f6274f43f8f968a6901694
DIST coreutils-9.3.tar.xz.sig 833 BLAKE2B c45ae10ff706907ae65d31228e432f7d6f34acbdb733bf521437d9e2fc75828a59da9d432d894a1ed8b7341f7e15d0e8d4e816e209c799b75c14d0ec055bfdf2 SHA512 522a2072f8ef940228ccdd856a4041c3c16b98e309168ccf2066fe7c1013685ba6cdea8a7317dfa1f4507b37ca016ecedaf54438d4a5007927b0e1a8fd223eb5
DIST coreutils-9.5-patches.tar.xz 5912 BLAKE2B 873fbe1a60f8f8034b3d35796146765ce388952d649c32dc81ca0e4c2823c9f2f00b69bc5cb3af686434867459b6dc378fb9a6d59563d28b87c3ee1eceeedbb3 SHA512 4b4ad356615d046b8d67ea35b789f887a787ab01ece3234f6344518aef33cd30ca364fef5d85e11acfdb24003114c16ffdab82922fb135d5425fbcd541064a76
DIST coreutils-9.5.tar.xz 6007136 BLAKE2B 6fd3a77697c9e85f31415c6ad66559faf18acc7d346677a89d4a999c2027886551e78842a7283e7b3b44fe8ef2fde04ba2f88df32a7844d5f69d45bcb7a04b6f SHA512 2ca0deac4dc10a80fd0c6fd131252e99d457fd03b7bd626a6bc74fe5a0529c0a3d48ce1f5da1d3b3a7a150a1ce44f0fbb6b68a6ac543dfd5baa3e71f5d65401c
DIST coreutils-9.5.tar.xz.sig 833 BLAKE2B 37c29984bceee0ff3bffde76712f71dbb118c228e328dc230d5c53c37da12f5ec2130e0123b97fda4a561f556c3be307fdbe1f0c21279db2c84030818386f626 SHA512 029997e0f4ee64e561853cff7c8a124f58cc891598595b44c4a46f9813b4b71c9d677464bc8a26d294e9971832f4b87c23777fea4fac6e8e30f06ad93b9957d5
349 changes: 349 additions & 0 deletions sys-apps/coreutils/coreutils-9.5.ebuild
Original file line number Diff line number Diff line change
@@ -0,0 +1,349 @@
# Copyright 1999-2024 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2

EAPI=8

# PREFIX LOCAL changes:
# - Solaris memset_s fix, that depends on coreutils pulling gnulib
# https://github.com/coreutils/gnulib/commit/4438332396e6e1f950862a32a71df511865b4069
# coreutils 9.6 probably has it as this commit suggests they updated
# https://github.com/coreutils/coreutils/commit/ea1fe48b91bfa9e8c4f952faf6b44fc1946e817b
# - Darwin libstdbuf cruft to fix during bootstrap, and use a correct
# install_name

# Try to keep an eye on Fedora's packaging: https://src.fedoraproject.org/rpms/coreutils
# The upstream coreutils maintainers also maintain the package in Fedora and may
# backport fixes which we want to pick up.
#
# Also recommend subscribing to the coreutils and bug-coreutils MLs.

PYTHON_COMPAT=( python3_{10..12} )
VERIFY_SIG_OPENPGP_KEY_PATH=/usr/share/openpgp-keys/coreutils.asc
inherit flag-o-matic python-any-r1 toolchain-funcs verify-sig

MY_PATCH="${PN}-9.5-patches"
DESCRIPTION="Standard GNU utilities (chmod, cp, dd, ls, sort, tr, head, wc, who,...)"
HOMEPAGE="https://www.gnu.org/software/coreutils/"

if [[ ${PV} == 9999 ]] ; then
EGIT_REPO_URI="https://git.savannah.gnu.org/git/coreutils.git"
inherit git-r3
elif [[ ${PV} == *_p* ]] ; then
# Note: could put this in devspace, but if it's gone, we don't want
# it in tree anyway. It's just for testing.
MY_SNAPSHOT="$(ver_cut 1-2).185-541b02"
SRC_URI="https://www.pixelbeat.org/cu/coreutils-${MY_SNAPSHOT}.tar.xz -> ${P}.tar.xz"
SRC_URI+=" verify-sig? ( https://www.pixelbeat.org/cu/coreutils-${MY_SNAPSHOT}.tar.xz.sig -> ${P}.tar.xz.sig )"
S="${WORKDIR}"/${PN}-${MY_SNAPSHOT}
else
SRC_URI="
mirror://gnu/${PN}/${P}.tar.xz
verify-sig? ( mirror://gnu/${PN}/${P}.tar.xz.sig )
"

KEYWORDS="~amd64-linux ~x86-linux ~arm64-macos ~ppc-macos ~x64-macos ~x64-solaris"
fi

SRC_URI+=" !vanilla? ( https://dev.gentoo.org/~sam/distfiles/${CATEGORY}/${PN}/${MY_PATCH}.tar.xz )"

LICENSE="GPL-3+"
SLOT="0"
IUSE="acl caps gmp hostname kill multicall nls +openssl selinux +split-usr static test vanilla xattr"
RESTRICT="!test? ( test )"

LIB_DEPEND="
acl? ( sys-apps/acl[static-libs] )
caps? ( sys-libs/libcap )
gmp? ( dev-libs/gmp:=[static-libs] )
openssl? ( dev-libs/openssl:=[static-libs] )
xattr? ( sys-apps/attr[static-libs] )
"
RDEPEND="
!static? ( ${LIB_DEPEND//\[static-libs]} )
selinux? ( sys-libs/libselinux )
nls? ( virtual/libintl )
"
DEPEND="
${RDEPEND}
static? ( ${LIB_DEPEND} )
"
BDEPEND="
app-arch/xz-utils
dev-lang/perl
test? (
dev-debug/strace
dev-lang/perl
dev-perl/Expect
${PYTHON_DEPS}
)
verify-sig? ( sec-keys/openpgp-keys-coreutils )
"
RDEPEND+="
hostname? ( !sys-apps/net-tools[hostname] )
kill? (
!sys-apps/util-linux[kill]
!sys-process/procps[kill]
)
!<sys-apps/util-linux-2.13
!<sys-apps/sandbox-2.10-r4
!sys-apps/stat
!net-mail/base64
!sys-apps/mktemp
!<app-forensics/tct-1.18-r1
!<net-fs/netatalk-2.0.3-r4
"

QA_CONFIG_IMPL_DECL_SKIP=(
# gnulib FPs (bug #898370)
unreachable MIN alignof static_assert
# ... and on musl
_exit fpurge statvfs64 re_set_syntax re_compile_pattern re_search re_match
)

pkg_setup() {
if use test ; then
python-any-r1_pkg_setup
fi
}

src_unpack() {
if [[ ${PV} == 9999 ]] ; then
git-r3_src_unpack

cd "${S}" || die
./bootstrap || die

sed -i -e "s:submodule-checks ?= no-submodule-changes public-submodule-commit:submodule-checks ?= no-submodule-changes:" gnulib/top/maint.mk || die
elif use verify-sig ; then
# Needed for downloaded patch (which is unsigned, which is fine)
verify-sig_verify_detached "${DISTDIR}"/${P}.tar.xz{,.sig}
fi

default
}

src_prepare() {
# TODO: past 2025, we may need to add our own hack for bug #907474.
local PATCHES=(
# Upstream patches
)

if ! use vanilla && [[ -d "${WORKDIR}"/${MY_PATCH} ]] ; then
PATCHES+=(
"${WORKDIR}"/${MY_PATCH}
"${FILESDIR}"/${PN}-9.5-skip-readutmp-test.patch
)
fi

default

# fixup libstdbuf non-libtool stuff
if [[ ${CHOST} == *-darwin* ]] ; then
# we need replacement libs from libcoreutils.a here in order
# to finish the linking (they try to avoid this, but it doesn't
# during bootstrap, a re-install is fine though)
sed -i \
-e "/src_libstdbuf_so_LDADD/s:$: lib/libcoreutils.a:" \
Makefile.in \
|| die
# and we need serial building :(
export MAKEOPTS+=" -j1"
# set a proper install_name
sed -i \
-e "/src_libstdbuf_so_LDFLAGS = -shared/s:-shared:-dynamiclib -install_name ${EPREFIX}/usr/libexec/coreutils/libstdbuf.dylib:" \
Makefile.in \
|| die

sed -i \
-e "s/libstdbuf\\.so/libstdbuf$(get_libname)/" \
src/stdbuf.c \
Makefile.in \
configure \
|| die
fi

# should be gone on next release, for memset_s breakage
[[ ${CHOST} == *-solaris* ]] && append-cppflags -D__STDC_WANT_LIB_EXT1__=1

# Since we've patched many .c files, the make process will try to
# re-build the manpages by running `./bin --help`. When doing a
# cross-compile, we can't do that since 'bin' isn't a native bin.
#
# Also, it's not like we changed the usage on any of these things,
# so let's just update the timestamps and skip the help2man step.
set -- man/*.x
touch ${@/%x/1} || die

# Avoid perl dep for compiled in dircolors default (bug #348642)
if ! has_version dev-lang/perl ; then
touch src/dircolors.h || die
touch ${@/%x/1} || die
fi
}

src_configure() {
# TODO: in future (>9.4?), we may want to wire up USE=systemd:
# still experimental at the moment, but:
# https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=85edb4afbd119fb69a0d53e1beb71f46c9525dd0
local myconf=(
--with-packager="Gentoo"
--with-packager-version="${PVR} (p${PATCH_VER:-0})"
--with-packager-bug-reports="https://bugs.gentoo.org/"
# kill/uptime - procps
# groups/su - shadow
# hostname - net-tools
--enable-install-program="arch,$(usev hostname),$(usev kill)"
--enable-no-install-program="groups,$(usev !hostname),$(usev !kill),su,uptime"
$(usev !caps --disable-libcap)
$(use_enable nls)
$(use_enable acl)
$(use_enable multicall single-binary)
$(use_enable xattr)
$(use_with gmp libgmp)
$(use_with openssl)
)

if use gmp ; then
myconf+=( --with-libgmp-prefix="${ESYSROOT}"/usr )
fi

if tc-is-cross-compiler && [[ ${CHOST} == *linux* ]] ; then
# bug #311569
export fu_cv_sys_stat_statfs2_bsize=yes
# bug #416629
export gl_cv_func_realpath_works=yes
fi

# bug #409919
export gl_cv_func_mknod_works=yes

if use static ; then
append-ldflags -static
# bug #321821
sed -i '/elf_sys=yes/s:yes:no:' configure || die
fi

if ! use selinux ; then
# bug #301782
export ac_cv_{header_selinux_{context,flash,selinux}_h,search_setfilecon}=no
fi

econf "${myconf[@]}"
}

src_test() {
# Non-root tests will fail if the full path isn't
# accessible to non-root users
chmod -R go-w "${WORKDIR}" || die
chmod a+rx "${WORKDIR}" || die

# coreutils tests like to do `mount` and such with temp dirs,
# so make sure:
# - /etc/mtab is writable (bug #265725)
# - /dev/loop* can be mounted (bug #269758)
mkdir -p "${T}"/mount-wrappers || die
mkwrap() {
local w ww
for w in "${@}" ; do
ww="${T}/mount-wrappers/${w}"
cat <<-EOF > "${ww}"
#!${EPREFIX}/bin/sh
exec env SANDBOX_WRITE="\${SANDBOX_WRITE}:/etc/mtab:/dev/loop" $(type -P ${w}) "\$@"
EOF
chmod a+rx "${ww}" || die
done
}
mkwrap mount umount

addwrite /dev/full

#local -x RUN_EXPENSIVE_TESTS="yes"
#local -x COREUTILS_GROUPS="portage wheel"
local -x PATH="${T}/mount-wrappers:${PATH}"
local -x gl_public_submodule_commit=

local xfail_tests=(
# bug #675802
tests/env/env-S
tests/env/env-S.pl

# bug #413621 and bug #548250
tests/du/long-from-unreadable.sh
tests/ls/removed-directory
tests/ls/removed-directory.sh
tests/ls/stat-free-symlinks
tests/ls/stat-free-symlinks.sh
tests/rm/deep-2
tests/rm/deep-2.sh

# We have a patch which fixes this (bug #259876)
#tests/touch/not-owner
#tests/touch/not-owner.sh
)

# This test is flaky (bug #629660, bug #935367).
cat > tests/dd/no-allocate.sh <<-EOF || die
#!/bin/sh
exit 77;
EOF

# This test is flaky (bug #910640).
cat > tests/tty/tty-eof.pl <<-EOF || die
#!/usr/bin/perl
exit 77;
EOF

# We set DISABLE_HARD_ERRORS because some of the tests hard error-out
# because of sandbox. They're skipped above but DISABLE_HARD_ERRORS is needed
# to downgrade them to FAIL.
emake -k check \
VERBOSE=yes \
DISABLE_HARD_ERRORS=yes \
XFAIL_TESTS="${xfail_tests[*]}"
}

src_install() {
default

insinto /etc
newins src/dircolors.hin DIR_COLORS

if use split-usr ; then
cd "${ED}"/usr/bin || die
dodir /bin

# Move critical binaries into /bin (required by FHS)
local fhs="cat chgrp chmod chown cp date dd df echo false ln ls
mkdir mknod mv pwd rm rmdir stty sync true uname"
mv ${fhs} ../../bin/ || die "Could not move FHS bins!"

if use hostname ; then
mv hostname ../../bin/ || die
fi

if use kill ; then
mv kill ../../bin/ || die
fi

# Move critical binaries into /bin (common scripts)
# (Why are these required for booting?)
local com="basename chroot cut dir dirname du env expr head mkfifo
mktemp readlink seq sleep sort tail touch tr tty vdir wc yes"
mv ${com} ../../bin/ || die "Could not move common bins!"

# Create a symlink for uname in /usr/bin/ since autotools require it.
# (Other than uname, we need to figure out why we are
# creating symlinks for these in /usr/bin instead of leaving
# the files there in the first place...)
local x
for x in ${com} uname ; do
dosym ../../bin/${x} /usr/bin/${x}
done
fi
}

pkg_postinst() {
ewarn "Make sure you run 'hash -r' in your active shells."
ewarn "You should also re-source your shell settings for LS_COLORS"
ewarn " changes, such as: source /etc/profile"
}
13 changes: 13 additions & 0 deletions sys-apps/coreutils/files/coreutils-9.5-skip-readutmp-test.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
https://bugs.gentoo.org/935367
--- a/gnulib-tests/test-readutmp.c
+++ b/gnulib-tests/test-readutmp.c
@@ -43,6 +43,9 @@ main (int argc, char *argv[])
STRUCT_UTMP *entries;
idx_t num_entries;

+ fprintf (stderr, "Skipping test: Gentoo: examines host entries, so unreliable in ebuild\n");
+ return 77;
+
if (read_utmp (UTMP_FILE, &num_entries, &entries, 0) < 0)
{
#if READ_UTMP_SUPPORTED

0 comments on commit af61f0a

Please sign in to comment.