Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully catch tile not found #1937

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

webb-ben
Copy link
Member

Overview

This PR introduces graceful catching of Not Found errors for a Tile provider. When a Tile provider raises ProviderTileNotFoundError the API returns a 404 gracefully.

Related Issue / discussion

#1936

Additional information

Willing to adapt the solution - but if the expected behavior is to return a 404, I think it does make sense to not log such behavior as an error.

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant