adding featureId to ldap schema #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvanderbiest
requested changes
Oct 1, 2019
| @@ -50,3 +50,11 @@ A LDAP attribute, representing a date of agreement on privacy policy. | |||
|
|
|||
| - partial OID: `1.2.1` | |||
| - complete OID: `1.3.6.1.4.1.53611.1.2.1` | |||
|
|
|||
| ### 1.2.2 | |||
There was a problem hiding this comment.
missing attribute name featureId
|
|
||
| ### 1.2.2 | ||
|
|
||
| A LDAP attribute, representing any kind of custom attribute. For exemple post codes, internal ids |
There was a problem hiding this comment.
It's not "any kind of custom attribute".
It's a numeric, more specifically a positive integer meant to identify a polygonal area.
There was a problem hiding this comment.
ah... So my definition of it in ldap is wrong. I choose a string repr: 1.3.6.1.4.1.1466.115.121.1.15
In the other hand, Bastia (corsica) have an inseeCode named 2B033.
Another example (still in France): Bourg-en-bresse 01053
There was a problem hiding this comment.
Good point.
Let's go for a string.
|
@RemiDesgrange can you refresh my memory - why was this contributed originally ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.