Skip to content

Commit

Permalink
Remove unused playwright setup from dashboard (#34110)
Browse files Browse the repository at this point in the history
We ended up removing these tests from CI due to flakiness and haven't gotten back around to re-adding them. If/when we decide to do this again, we can start from scratch

GitOrigin-RevId: 1b97e91cc34e06b6ea4de13cdbac441387087680
  • Loading branch information
atrakh authored and Convex, Inc. committed Feb 5, 2025
1 parent 24da068 commit e41f994
Show file tree
Hide file tree
Showing 8 changed files with 4 additions and 170 deletions.
8 changes: 4 additions & 4 deletions npm-packages/common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion npm-packages/dashboard/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ yarn-error.log*
# typescript
*.tsbuildinfo

playwright/.auth
.env*.local

src/hooks/generated
17 changes: 0 additions & 17 deletions npm-packages/dashboard/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,23 +74,6 @@ GitHub pull requests.

### Integration tests

#### Run playwright tests

the hardcoded credentials are for local development web-servers only

You need to set some env vars to provide credentials, see the "How to run
dashboard E2E tests locally" note in 1password for the full text you can copy.

```
npm run test:e2e
```

The dashboard uses playwright for end-to-end testing to reduce regressions
between backend/big-brain and the dashboard.

These tests are also run in CI against the latest vercel preview for your
branch.

## Bundle size

You can analyze the bundle size of the dashboard by running
Expand Down
27 changes: 0 additions & 27 deletions npm-packages/dashboard/e2e/auth.setup.ts

This file was deleted.

61 changes: 0 additions & 61 deletions npm-packages/dashboard/e2e/basic.spec.ts

This file was deleted.

1 change: 0 additions & 1 deletion npm-packages/dashboard/jest.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ const customJestConfig = {
moduleDirectories: ["node_modules", "src"],
testEnvironment: "jest-environment-jsdom",
setupFilesAfterEnv: ["<rootDir>/setupTests.ts"],
testPathIgnorePatterns: ["e2e"],
moduleNameMapper: {
"react-dnd": "<rootDir>/__mocks__/fileMock.js",
"react-dnd-scrolling": "<rootDir>/__mocks__/fileMock.js",
Expand Down
2 changes: 0 additions & 2 deletions npm-packages/dashboard/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"storybook": "storybook dev -s ./public -p 6006",
"build-storybook": "storybook build",
"test": "npm run checkApiSpec && npm run build:generated && jest",
"test:e2e": "playwright test",
"clean": "shx rm -rf .next",
"corsAnywhere": "node cors-anywhere.js",
"pullEnv": "vercel env pull .env.local",
Expand Down Expand Up @@ -63,7 +62,6 @@
"devDependencies": {
"@babel/core": "^7.20.5",
"@jest/types": "^29.6.0",
"@playwright/test": "1.49.1",
"@storybook/addon-essentials": "^7.6.16",
"@storybook/addon-interactions": "^7.6.16",
"@storybook/addon-links": "^7.6.16",
Expand Down
57 changes: 0 additions & 57 deletions npm-packages/dashboard/playwright.config.ts

This file was deleted.

0 comments on commit e41f994

Please sign in to comment.