million checkboxes ui #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrakh
approved these changes
Nov 5, 2024
ianmacartney
reviewed
Nov 5, 2024
| @@ -4,8 +4,9 @@ | |||
| "type": "module", | |||
| "version": "0.0.0", | |||
| "scripts": { | |||
| "dev": "convex dev --live-component-sources", | |||
| "dev:backend": "convex dev --live-component-sources", | |||
There was a problem hiding this comment.
shouldn't this have --typecheck-components too?
There was a problem hiding this comment.
is that in the template now? i can add it
Comment on lines
+99
to
+122
| export const seed = internalMutation({ | ||
| args: {}, | ||
| handler: async (ctx) => { | ||
| const boxes = await ctx.db | ||
| .query("checkboxes") | ||
| .withIndex("idx") | ||
| .order("asc") | ||
| .collect(); | ||
| // Clear the table. | ||
| for (const box of boxes) { | ||
| await ctx.db.delete(box._id); | ||
| } | ||
|
|
||
| const bytes = new Uint8Array(BOXES_PER_DOCUMENT / 8); | ||
|
|
||
| // Reset the table. | ||
| for (let i = 0; i < NUM_DOCUMENTS; i++) { | ||
| await ctx.db.insert("checkboxes", { | ||
| idx: i, | ||
| boxes: bytes.buffer, | ||
| }); | ||
| } | ||
| }, | ||
| }); |
There was a problem hiding this comment.
do you still need this?
|
yes it's in the template. The template has been kept up to date, but
unfortunately it's not trivial to just rebase / merge all the components
(or maybe it is with something like `git patch apply`?)
…On Tue, Nov 5, 2024 at 8:17 AM Lee Danilek ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In example/package.json
<#7 (comment)>
:
> @@ -4,8 +4,9 @@
"type": "module",
"version": "0.0.0",
"scripts": {
- "dev": "convex dev --live-component-sources",
+ "dev:backend": "convex dev --live-component-sources",
is that in the template now? i can add it
—
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACZQW6RBAE5OZUVD72ZFQ3Z7DVRNAVCNFSM6AAAAABRFLN7DGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMJWGEYDKNJRG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
customers are requesting an example repo for a component that has a UI, so let's give them one.
shamelessly copied from https://github.com/atrakh/one-million-checkboxes
two small changes:
seedBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.