-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added safe_email filter for email field #480
base: develop
Are you sure you want to change the base?
Conversation
Note: This requires grav 1.7.0-rc.18, as safe_email got fixed there: getgrav/grav@068de42
Interesting... Hide emails in the forms... |
It only hides the default emails. Example: I also wanted to add this for the telephone field afterwards. |
Since the other PR got rejected: What about this one? I've simply copied the general field template, so everything should be still compatible. I know that emails are not iterable, maybe we can remove it in this field. What do you think? |
I'm not sure how this will save after it has rendered with the safe_email filter applied? |
I dont understand your comment, sorry... The filter will just obfuscate the email. I am using this for every email on my webpage and I noticed, that prefilled forms are lacking this filter. It does not hurt to have it there I think. |
When it’s prefilled obfuscated and you submit again, it will submit obfuscated right? Imagine you have a user profile with email field. When the profile loads and the raw value gets manipulated to show the safe version of it, it means that if I save the profile again it will now be storing the value obfuscated (in yaml or wherever it’s going to be used). That’s the issue I’m taking about. Am I missing something? |
It does not submit any obfuscated text. You can encode every html character like this. Did you try this? I guess you assumption was just wrong. |
I'm going to test this one after the next release. |
Any updates? |
Note: This requires grav 1.7.0-rc.18, as safe_email got fixed there:
getgrav/grav@068de42
Please have a look at #477 first. I will rebase afterwards.