New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend modular blueprint to add header.onpage_menu #92

Open

flaviocopes wants to merge 1 commit into develop from feature/extend-modular-blueprint

Contributor

flaviocopes commented Feb 1, 2017

No description provided.


          Extend modular blueprint to add header.onpage_menu

bc2b727

flaviocopes mentioned this pull request

Add onpage_menu option in the admin for modulars #91

Open

Contributor

olivierdalang commented Feb 1, 2017

Heh that was quick. I just tested, it works, but :

it writes onpage_menu: '0' or onpage_menu: '1' to the file. I guess onpage_menu: false / onpage_menu: true would be cleaner
it takes two actions to change the default behaviour (which is to display the single page menu) : you must activate the option, and set it to "disabled", which is a bit counter intuitive I guess. Is it possible to have the default to "disabled" so that you just need to activate the option ?

Thanks for super-fast support :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet