Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: twig filter exif_read_data throws critical error #3878

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions system/src/Grav/Common/Twig/Extension/FilesystemExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -272,13 +272,13 @@ public function getimagesize($filename)
* @param bool $read_thumbnail
* @return array|false
*/
public function exif_read_data($filename, ?string $required_sections, bool $as_arrays = false, bool $read_thumbnail = false)
public function exif_read_data($filename, ?string $required_sections = null, bool $as_arrays = false, bool $read_thumbnail = false)
{
if (!Utils::functionExists('exif_read_data') || !$this->checkFilename($filename)) {
return false;
}

return exif_read_data($filename, $required_sections, $as_arrays, $read_thumbnail);
return @exif_read_data($filename, $required_sections, $as_arrays, $read_thumbnail);
}

/**
Expand Down
Loading