Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't copy file ownership, permissions and metadata #3228

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

boxydog
Copy link
Contributor

@boxydog boxydog commented Oct 29, 2023

Pull Request Checklist

Resolves: #1463
Supercedes: #3101

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

@boxydog boxydog marked this pull request as draft October 29, 2023 17:56
Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Originally someone wanted the current behavior, where things like mtime were preserved. I don't know if there are people who currently rely on this behavior, but if so, I am fine with putting the onus on them to submit a separate pull request to add an option that restores that capability for them.

@justinmayer justinmayer requested a review from avaris October 29, 2023 18:47
@justinmayer justinmayer added this to the Pelican 4.9 milestone Oct 29, 2023
@justinmayer justinmayer marked this pull request as ready for review October 29, 2023 19:00
@justinmayer justinmayer removed this from the Pelican 4.9 milestone Oct 29, 2023
@justinmayer justinmayer merged commit bfb2587 into getpelican:master Oct 29, 2023
kernc added a commit to efck-chat-keyboard/efck-chat-keyboard.github.io that referenced this pull request Jan 4, 2024
@boxydog boxydog deleted the fix_1463 branch May 31, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copying themes should set correct permissions for the local "output" directory.
2 participants