Apply code style to project #3231
Conversation
- remove upper version caps - updated the minimum version of most of Pelican's runtime deps - replaced black with ruff as a formatter for pelican - added a cache step to the docs CI task so that the docs can be downloaded and inspected.
|
Assuming the SHA doesn't change for the commit titled Apply code style to project via: ruff format ., before this PR is merged, the following commit hash should be added to the |
|
Oof, the double quotes. I don't object, but this really rules out any automated resolution of any existing PRs. But, I approve of forward motion! |
pyproject.toml
Outdated
| "flake8>=6.1.0", | ||
| "flake8-import-order>=0.18.2", | ||
| "invoke>=2.2.0", | ||
| "isort>=5.12.0", |
There was a problem hiding this comment.
Shouldn't isort be removed then?
| "isort>=5.12.0", |
There was a problem hiding this comment.
I believe so, and for that matter I think Flake8 and Black should also be removed, right @offbyone?
There was a problem hiding this comment.
I am not @offbyone, but I don't see black or isort in .pre-commit-config.yaml, so I agree.
There was a problem hiding this comment.
Correct; I left them in on the chance that someone ran them by hand, but yeah, they should be yeeted.
|
Many thanks to @boxydog, @offbyone, @lioman, and @pauloxnet for helping with this endeavor. Much appreciated! 🤗 |
downloaded and inspected.
Resolves #3217
Resolves #3227
Closes #3123