test: Fix test_typogrify_ignore_tags due to Typogrify 2.1 changes
#3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidlesieur: I just released Typogrify 2.1. Could you double-check and ensure tests will pass successfully with the new release? |
justinmayer
changed the title
justinmayer
changed the title
test_typogrify_ignore_tags due to Typogrify 2.1 changes
Typogrify's 'widont' filter used to ignore the list of 'ignore_tags', but this got fixed in Typogrify.
justinmayer
force-pushed
the
typogrify-test-ignore-tags
branch
from
703b531 to
b4fcb7f
Compare
pauloxnet
approved these changes
Jan 14, 2025
justinmayer
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Many thanks to @davidlesieur for the enhancement and to @pauloxnet for reviewing 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typogrify's 'widont' filter used to ignore the list of 'ignore_tags', but this will be fixed in an upcoming version of Typogrify.
The tests will fail with Typogrify 2.0.7 but work with justinmayer/typogrify#1.
Pull Request Checklist