Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add setting to omit selected Typogrify filters. Fixes #3436 #3439

Merged

Conversation

davidlesieur
Copy link
Contributor

Remarks:

Pull Request Checklist

Resolves: #3436

  • Ensured tests pass and (if applicable) updated functional test output ⚠️ See condition above!
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, David! I made a few comments and look forward to your thoughts.

docs/settings.rst Show resolved Hide resolved
docs/settings.rst Outdated Show resolved Hide resolved
pelican/tests/test_readers.py Outdated Show resolved Hide resolved
@justinmayer justinmayer changed the title Let user select Typogrify filters to omit (#3436). Add setting to omit selected Typogrify filters. Fixes: #3436 Jan 8, 2025
@justinmayer justinmayer changed the title Add setting to omit selected Typogrify filters. Fixes: #3436 Add setting to omit selected Typogrify filters. Fixes #3436 Jan 8, 2025
@justinmayer justinmayer changed the title Add setting to omit selected Typogrify filters. Fixes #3436 feat: Add setting to omit selected Typogrify filters. Fixes #3436 Jan 8, 2025
@justinmayer
Copy link
Member

@davidlesieur: I just released Typogrify 2.1. Could you double-check and ensure tests will pass successfully with the new release? (They failed when I tested locally).

Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for all your work on this feature, David! 🥇

@justinmayer justinmayer merged commit 9207e1f into getpelican:main Jan 14, 2025
18 checks passed
@justinmayer
Copy link
Member

I just released Pelican 4.11.0, which includes the changes in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using a subset of Typogrify filters
2 participants