Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update link to re-directed example settings file #3445

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

amites
Copy link
Contributor

@amites amites commented Jan 7, 2025

Update the reference links in the docs, was using an old pattern that no longer works

Pull Request Checklist

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

@justinmayer
Copy link
Member

Hi Alvin. What does “no longer works” mean in this context? When I try to load the original URL…

https://github.com/getpelican/pelican/raw/main/samples/pelican.conf.py

… it is automatically re-directed to:

https://raw.githubusercontent.com/getpelican/pelican/main/samples/pelican.conf.py

@amites
Copy link
Contributor Author

amites commented Jan 8, 2025

interesting, I got a 404 not found on 3 different browsers

was easy to fix manually so figured I'd do that


just tested and now it's working on the same browsers that were failing yesterday
maybe it was a temporary github issue

can merge or close this at your discretion

@justinmayer justinmayer changed the title Updated link to github example settings file chore: Update link to re-directed example settings file Jan 15, 2025
Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might as well use the re-directed version of the URL, so thank you for proposing this change. Much appreciated! 👍

@justinmayer justinmayer merged commit 4878fc8 into getpelican:main Jan 15, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants