Ensure all keywords are stringified by java-util-hashmappify-vals #68
Conversation
Change java-util-hashmappify-vals to also change keywords to strings for lone values nested under a map's direct values. When postwalk would encounter a non-map value, the value would be returned as-is. This means a keyword which would be nested inside another non-map structure would not be converted to a string. For maps, if the keys or values are keywords themselves, it would always directly convert them into strings, which masked the problem. This results in weird-looking serialization which exposes the underlying Java Keyword object, as per getsentry#67.
Instead of doing the map? test twice, do it once, using postwalk. Postwalk already traverses all objects depth-first, so there's no need to test for map? again in the inner "f" function. To preserve existing functionality, use walk on the outer map (or whatever object) to prevent it from being converted to a HashMap. Add a test for the class of the resulting value and nested values to ensure the functionality is still as before.
|
The second commit can be simplified further by dropping the outer |
|
Hi! Looks good! Thank you kindly for your contribution. -=david=- |
Thanks David! I'd still be interested to learn the reason why the outer map isn't transformed to a |
|
Hi, TBH, it's not something that I've spent much time looking at. I inherited the codebase, did a bit of tidy up, added some new things and generally maintain it. If you think that it's better to transform to a hashmap, then sure, do a PR, let's look at it and we'll see :-) -=david=- |
Change
java-util-hashmappify-valsto also change keywords to strings for lone values nested under a map's direct values.When
postwalkwould encounter a non-map value, the value would be returned as-is. This means a keyword which would be nested inside another non-map structure would not be converted to a string. For maps, if the keys or values are keywords themselves, it would always directly convert them into strings, which masked the problem.This results in weird-looking serialization which exposes the underlying Java Keyword object, as per #67.