Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction Source Enum #2696

Open
szokeasaurusrex opened this issue Feb 1, 2024 · 0 comments · May be fixed by #3889
Open

Transaction Source Enum #2696

szokeasaurusrex opened this issue Feb 1, 2024 · 0 comments · May be fixed by #3889
Labels
Component: SDK Core Dealing with the core of the SDK Good first issue Good for newcomers Hacktoberfest 🎃 Issues eligible for Hacktoberfest! Triaged Has been looked at recently during old issue triage

Comments

@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented Feb 1, 2024 •
edited
Loading

The TRANSACTION_SOURCE_* constants defined in tracing.py would likely make more sense to be defined as enums. We can then redefine the functions that accept as an argument a transaction source (for example, scope.set_transaction_name) to accept the Transaction Source enum type.
@antonpirker antonpirker added Enhancement Component: SDK Core Dealing with the core of the SDK labels Jun 7, 2024
@szokeasaurusrex szokeasaurusrex added Good first issue Good for newcomers Triaged Has been looked at recently during old issue triage labels Oct 7, 2024
@antonpirker antonpirker added the Hacktoberfest 🎃 Issues eligible for Hacktoberfest! label Oct 10, 2024
mgaligniana added a commit to mgaligniana/sentry-python that referenced this issue Dec 22, 2024
@mgaligniana
ref(tracing): Move TRANSACTION_SOURCE_* constants to Enum
dbac53a 
Fixes getsentryGH-2696
@mgaligniana mgaligniana linked a pull request Dec 22, 2024 that will close this issue
Open
mgaligniana added a commit to mgaligniana/sentry-python that referenced this issue Dec 22, 2024
@mgaligniana
ref(tracing): Move TRANSACTION_SOURCE_* constants to Enum
f4bb234 
Fixes getsentryGH-2696
mgaligniana added a commit to mgaligniana/sentry-python that referenced this issue Dec 22, 2024
@mgaligniana
ref(tracing): Move TRANSACTION_SOURCE_* constants to Enum
ef97faa 
Fixes getsentryGH-2696
antonpirker added a commit to mgaligniana/sentry-python that referenced this issue Dec 23, 2024
@antonpirker
Merge branch 'master' into getsentryGH-2696-transaction-source-enum
48f0f31
mgaligniana added a commit to mgaligniana/sentry-python that referenced this issue Dec 23, 2024
@mgaligniana
ref(tracing): Move TRANSACTION_SOURCE_* constants to Enum
3082f96 
Fixes getsentryGH-2696
mgaligniana added a commit to mgaligniana/sentry-python that referenced this issue Dec 23, 2024
@mgaligniana
ref(tracing): Move TRANSACTION_SOURCE_* constants to Enum
450a045 
Fixes getsentryGH-2696
mgaligniana added a commit to mgaligniana/sentry-python that referenced this issue Dec 23, 2024
@mgaligniana
ref(tracing): Move TRANSACTION_SOURCE_* constants to Enum
b016caf 
Fixes getsentryGH-2696
mgaligniana added a commit to mgaligniana/sentry-python that referenced this issue Dec 23, 2024
@mgaligniana
ref(tracing): Move TRANSACTION_SOURCE_* constants to Enum
79f20d7 
Fixes getsentryGH-2696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: SDK Core Dealing with the core of the SDK Good first issue Good for newcomers Hacktoberfest 🎃 Issues eligible for Hacktoberfest! Triaged Has been looked at recently during old issue triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref(tracing): Move TRANSACTION_SOURCE_* constants to Enum mgaligniana/sentry-python
2 participants
@antonpirker @szokeasaurusrex