-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(tracing): Move TRANSACTION_SOURCE_*
constants to Enum
#3889
base: master
Are you sure you want to change the base?
ref(tracing): Move TRANSACTION_SOURCE_*
constants to Enum
#3889
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3889 +/- ##
==========================================
- Coverage 79.89% 79.80% -0.09%
==========================================
Files 139 139
Lines 15417 15419 +2
Branches 2623 2624 +1
==========================================
- Hits 12317 12305 -12
- Misses 2227 2245 +18
+ Partials 873 869 -4
|
f4bb234
to
ef97faa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! thanks for the cleanup
This breaks a lot of tests, because the full enum ends up in the envelope that is sent to Sentry and not the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the tests, by making sure the .value
of the enum (the string) ends up in the envelop json payload that is sent to Sentry.
Head branch was pushed to by a user without write access
450a045
to
b016caf
Compare
b016caf
to
79f20d7
Compare
Thank you @antonpirker! Now linter and tests passing! 💪 |
Fixes GH-2696