Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(tracing): Move TRANSACTION_SOURCE_* constants to Enum #3889

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgaligniana
Copy link
Contributor

Fixes GH-2696

@mgaligniana mgaligniana marked this pull request as draft December 22, 2024 03:28
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.80%. Comparing base (bb85c26) to head (79f20d7).

Files with missing lines Patch % Lines
sentry_sdk/integrations/fastapi.py 50.00% 1 Missing ⚠️
sentry_sdk/integrations/gcp.py 0.00% 1 Missing ⚠️
sentry_sdk/integrations/litestar.py 50.00% 1 Missing ⚠️
sentry_sdk/integrations/starlette.py 66.66% 1 Missing ⚠️
sentry_sdk/integrations/starlite.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3889      +/-   ##
==========================================
- Coverage   79.89%   79.80%   -0.09%     
==========================================
  Files         139      139              
  Lines       15417    15419       +2     
  Branches     2623     2624       +1     
==========================================
- Hits        12317    12305      -12     
- Misses       2227     2245      +18     
+ Partials      873      869       -4     
Files with missing lines Coverage Δ
sentry_sdk/integrations/aiohttp.py 78.21% <ø> (ø)
sentry_sdk/integrations/arq.py 86.82% <100.00%> (ø)
sentry_sdk/integrations/asgi.py 85.61% <100.00%> (ø)
sentry_sdk/integrations/aws_lambda.py 28.43% <100.00%> (-2.95%) ⬇️
sentry_sdk/integrations/celery/__init__.py 85.77% <100.00%> (ø)
sentry_sdk/integrations/chalice.py 89.18% <100.00%> (ø)
sentry_sdk/integrations/django/__init__.py 81.00% <100.00%> (ø)
sentry_sdk/integrations/grpc/aio/server.py 86.44% <100.00%> (ø)
sentry_sdk/integrations/grpc/server.py 76.31% <100.00%> (ø)
sentry_sdk/integrations/huey.py 91.66% <ø> (ø)
... and 13 more

... and 3 files with indirect coverage changes

@mgaligniana mgaligniana force-pushed the GH-2696-transaction-source-enum branch 2 times, most recently from f4bb234 to ef97faa Compare December 22, 2024 04:51
@mgaligniana
Copy link
Contributor Author

Linter is failing because of:

image

Should I fix them in a different commit?

@mgaligniana mgaligniana marked this pull request as ready for review December 22, 2024 04:54
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks for the cleanup

@antonpirker
Copy link
Member

antonpirker commented Dec 23, 2024

Linter is failing because of:

image

Should I fix them in a different commit?

no, this is because of a new release of mypy. I will fix this.

@antonpirker antonpirker enabled auto-merge (squash) December 23, 2024 09:02
@antonpirker
Copy link
Member

This breaks a lot of tests, because the full enum ends up in the envelope that is sent to Sentry and not the .value of the enum. Can you please fix this?

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the tests, by making sure the .value of the enum (the string) ends up in the envelop json payload that is sent to Sentry.

auto-merge was automatically disabled December 23, 2024 13:37

Head branch was pushed to by a user without write access

@mgaligniana mgaligniana force-pushed the GH-2696-transaction-source-enum branch 3 times, most recently from 450a045 to b016caf Compare December 23, 2024 13:41
@mgaligniana mgaligniana force-pushed the GH-2696-transaction-source-enum branch from b016caf to 79f20d7 Compare December 23, 2024 13:51
@mgaligniana
Copy link
Contributor Author

Thank you @antonpirker! Now linter and tests passing! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transaction Source Enum
2 participants