Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR containing a test for #3111. In order to implement this change, we first would need to modify our test suite to allow running tests against both psycopg2 and 3. For testing purposes, this change modifies our test suite to only run against psycopg3; we would undo this change before merging
The main challenge preventing this change from working is an error occurring during test teardown. The test itself passes; the teardown error is the only problem. The test also tests the feature as intended: if we undo the change from #3111, the test fails.
Adding
transaction=True
to the Pytest-Django decorator eliminates the teardown error allowing the test to pass; however, if we undo #3111, the test still passes, indicating that running withtransaction=True
does not properly test the functionality we wish to verify.Resolves #3139