Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove Pytest pin #3693

Closed
wants to merge 1 commit into from
Closed

Conversation

szokeasaurusrex
Copy link
Member

Remove Pytest pin. This requires ensuring that any test modules which contain both forked and non-forked tests do not have a forked test as the last test in the module. See here.

Closes #3035

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (72f4d99) to head (26806ef).
Report is 10 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3693   +/-   ##
=======================================
  Coverage   84.34%   84.34%           
=======================================
  Files         133      133           
  Lines       14257    14257           
  Branches     2405     2405           
=======================================
  Hits        12025    12025           
  Misses       1482     1482           
  Partials      750      750           

see 2 files with indirect coverage changes

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/unpin-pytest branch 2 times, most recently from 0d2a5f0 to 5ba3469 Compare October 28, 2024 10:01
Remove Pytest pin. This requires ensuring that any test modules which contain both forked and non-forked tests do not have a forked test as the last test in the module. See [here](pytest-dev/pytest-forked#67 (comment)).

Closes #3035
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/unpin-pytest branch from 5ba3469 to 26806ef Compare October 28, 2024 10:17
@szokeasaurusrex
Copy link
Member Author

All tests have already passed; CI is now rerunning because I rebased on master

@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review October 28, 2024 10:18
@szokeasaurusrex szokeasaurusrex marked this pull request as draft October 28, 2024 10:38
@szokeasaurusrex
Copy link
Member Author

szokeasaurusrex commented Oct 28, 2024

modifying the tests may not be needed, after all: #3696
nvm: looks like this change does not fully remove the pin

@szokeasaurusrex
Copy link
Member Author

This has been superseded by some other PRs incrementally removing the pin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin pytest
1 participant