fix: CI - Set correct Java version #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
approved these changes
Jan 10, 2025
.github/workflows/ci.yml
Outdated
| Write-Host "Using Java 8 for Unity 2019" | ||
| } | ||
| "2022" { | ||
| $javaHome = "$env:JAVA_HOME_11_X64" |
There was a problem hiding this comment.
Do these need to be installed by us before hand or they are part of the build agent's image?
If something is missing (one of these paths is empty/undefined) how does the error manifest? Do we have some sane way to immediately stop saying "Didn't find X, we need that to work"
There was a problem hiding this comment.
They are part of the runner image until they aren't anymore 😢 Especially Java 8 for Unity 2019.
Good call. I've added some path validation with proper logs to it too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default Java version is different on different runner images. An update to
-latestcauses Unity 2019 builds to fail.With this, we explicitly set the correct Java version depending on the targeted Unity version, making this more resilient to future changes.
I've also added timeouts to the smoketests themselves. They tend to either fail fast or run indefinitely. This gets rid of the latter.
#skip-changelog