Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update to Unity 2022.3.55f1 #1957

Merged
merged 4 commits into from
Jan 13, 2025
Merged

fix: Update to Unity 2022.3.55f1 #1957

merged 4 commits into from
Jan 13, 2025

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Jan 10, 2025

The current LTS of Unity requires a bump to ndk: "r23b".
This PR contains workarounds for an ongoing issue with the current 2022 LTS. This requires us to fix an additional absolut path set in the gradle properties and to pin the targeted Android API target.

Additionally, for mobile project compilation, we're running on the big runners to stop the gradle build process to run out of memory.

#skip-changelog

@bruno-garcia bruno-garcia requested a review from vaind January 10, 2025 19:20
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry about how many different versions and checks are spread throughout the repo to get this to work. Is there a world we can keep a map of versions in a single file for example, that we parse and then things run on the correct version?

assigned @vaind for review here since he touched a lot of this stuff too

Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

Base automatically changed from fix/ci-java to main January 13, 2025 12:27
@bitsandfoxes bitsandfoxes merged commit 54613dd into main Jan 13, 2025
13 checks passed
@bitsandfoxes bitsandfoxes deleted the fix/unity-2022 branch January 13, 2025 12:41
@bitsandfoxes
Copy link
Contributor Author

I worry about how many different versions and checks are spread throughout the repo to get this to work. Is there a world we can keep a map of versions in a single file for example, that we parse and then things run on the correct version?

I get that and parts of it make me nervous too. But we've got the individual changes and checks bundled in their respective place, i.e.

  • modify-gradle-project.ps1 contains all the changes to the exported gradle project to make it build in CI.
  • Builder.cs contains all the changes necessary to properly create an artifact in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants