feat(eap): Start decoupling EAP entities at the entity layer #6701
+241
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-sentry
force-pushed
the
eap_entity_2
branch
from
90a00bc to
cc646b9
Compare
colin-sentry
force-pushed
the
eap_entity_2
branch
from
693b230 to
cc41bc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently a big chunk of code in
common.pythat maps column accesses to the correct place.However, it's all hard-coded to the spans table right now.
We would like to add new non-span entity types to the EAP RPCs, and the easiest place to do that is at the entity layer.
This essentially hides the 'real columns' behind a well-known set of columns (
organization_id,attr_str,attr_f64,attr_i64, ...) which will be shared across all EAP entities.When we add new entities, we can specify in the entity YAML what maps where in a way that the RPC doesn't have to know what type of entity is being processed.
Works towards solving https://github.com/getsentry/eap-planning/issues/126