Let extra_syntaxes_and_themes reference builtin syntaxes
#2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: port zola release build to gh actions & support linux arm64 Signed-off-by: Henrik Gerdes <[email protected]> * fix: add buildx support for multi-arch docker images Signed-off-by: Henrik Gerdes <[email protected]> * fix: pin gh release action to sha & allow pre-releases Signed-off-by: Henrik Gerdes <[email protected]> * fix: use env in gh action for linux arm build Signed-off-by: Henrik Gerdes <[email protected]> * chore: switch to dtolnay/rust-toolchain action for rust setup Signed-off-by: Henrik Gerdes <[email protected]> * fix: windows archive step Signed-off-by: Henrik Gerdes <[email protected]> --------- Signed-off-by: Henrik Gerdes <[email protected]>
Signed-off-by: xixishidibei <[email protected]>
Having a crate depend on files outside of its directory breaks building Zola as a dependency using Nix
* Add pagination info to get_section * Add documentation for pagination information * Stick to section properties `paginated` attributes removed
…nt (getzola#2688) This adds semantic meaning to the footnotes organization and improves accessibility by aiding disabled users who rely on assistive devices such as screen readers which utilize semantic tags such as the footer element in order to navigate properly. The hr element is semantically defined as representing a paragraph-level thematic break. Now that the footnotes are descendants of the footer element, the hr element originally preceding the footnotes list is no longer necessary (footnotes are no longer paragraph-level content) and thus replaced. However, the footer element is given the class "footnotes" to allow for styling, so the following CSS could be used to provide a stylistically equivalent visible border separating the footnotes from the content if so desired: .footnotes { border-top: 2px groove gray; } Test snapshots are also updated to reflect the new footer elements.
* Add external links class option to Markdown configuration * Validate external links class * Rename external link test snapshots
…n-minify-html * feat: do not minify js when minify html * test: update tests
|
That's a huge slowdown. Let's see if someone from syntect can weight in because that's too much IMO |
|
@Keats Yeah, agreed. I opened an issue upstream, we'll see what they think: trishume/syntect#562 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1607
Closes #1678
This lets syntax definitions in
extra_syntaxes_and_themesreference builtin syntaxes (byscope:orinclude:or similar).Unfortunately, re-building the
SyntaxSetis rather expensive. On my (small) personal website, this makes Zola render my site in 469ms rather than 63ms — a slowdown of nearly 8x!We could potentially mitigate this by serializing the computed
SyntaxSetto a file, for example with acached::DiskCache, but I don't see existing caching infrastructure so I'm not sure if that's a good tradeoff.Is this wanted? The performance cost is not worth it with the current implementation, but maybe we can optimize it?
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?If the change is a new feature or adding to/changing an existing one: