Skip to content

Commit

Permalink
Fix Windows+macOS CI by updating to Python 3.11. (iree-org#19029)
Browse files Browse the repository at this point in the history
Pending CI builds (since these are nightly / on-demand and take hours):
* Windows: https://github.com/iree-org/iree/actions/runs/11689195978
* macOS: https://github.com/iree-org/iree/actions/runs/11689197108

The new `iree.build` package depends on Python 3.11:
iree-org#18630 (comment). We
currently publish Python packages for 3.9+ on Linux but only 3.11+ on
macOS and Windows:
*
https://github.com/iree-org/iree/blob/9650bfe441d5f8ce4a16395ee6b3ad43968caa2e/build_tools/python_deploy/build_linux_packages.sh#L68
*
https://github.com/iree-org/iree/blob/9650bfe441d5f8ce4a16395ee6b3ad43968caa2e/.github/workflows/build_package.yml#L259-L266
*
https://github.com/iree-org/iree/blob/9650bfe441d5f8ce4a16395ee6b3ad43968caa2e/.github/workflows/build_package.yml#L247-L254

We can relax the 3.11 dependency in the package, but we might as well
update these workflows to test with the version that we distribute
packages for.

Signed-off-by: Giacomo Serafini <[email protected]>
  • Loading branch information
ScottTodd authored and giacs-epic committed Dec 4, 2024
1 parent f1f5674 commit c92da58
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci_macos_x64_clang.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: "Setting up Python"
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.1.0
with:
python-version: "3.10"
python-version: "3.11"
cache: "pip"
- name: "Installing Python packages"
run: pip install -r runtime/bindings/python/iree/runtime/build_requirements.txt
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci_windows_x64_msvc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: "Setting up Python"
uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.1.0
with:
python-version: "3.10" # Needs pybind >= 2.10.1 for Python >= 3.11
python-version: "3.11"
- name: "Installing Python packages"
run: |
python3 -m venv .venv
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ def testBuildNonDefaultSubTarget(self):
mod, args=["mnist/mnist.mlir"] + DEFAULT_TARGET_ARGS, stdout=out_file
)
output = out_file.getvalue().strip()
self.assertIn("genfiles/mnist/mnist.mlir", output)
output_path = Path(output)
self.assertIn("genfiles/mnist/mnist.mlir", output_path.as_posix())
contents = output_path.read_text()
self.assertIn("module", contents)

Expand Down

0 comments on commit c92da58

Please sign in to comment.