Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build freethreading wheels #2491

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Dec 29, 2024

Summary

Description

build freethreading wheels
fix tests issues discovered while adding those

Does nothing on Darwin / macOS but that's supported.
On macOS, at least on macOS arm64>=14, python3.13t, there's an existing UNIX socket on syslog.
Rework the test to ignore pre-existing sockets & just search for the newly created one.
@mayeut
Copy link
Contributor Author

mayeut commented Dec 29, 2024

The macOS-14 failure is just a flaky test. Nothing to do with this PR.

@giampaolo
Copy link
Owner

giampaolo commented Dec 30, 2024

Sorry for the probably noob questions, but here goes:

  1. How many additional .whl files does this produce? For what platforms?
  2. How many additional test runs / jobs are being executed?
  3. Are additional unit tests run specifically for free-thread python? Or this just produces the .whl file without running tests?

@mayeut
Copy link
Contributor Author

mayeut commented Dec 30, 2024

How many additional .whl files does this produce? For what platforms?

This generates 1 additional wheel per axis in the build matrix so 7 additional wheels (2 for macOS, 2 for Windows, 3 for Linux). It only needed tweaking cibuildwheel configuration in order to build & tests those wheels.

How many additional test runs / jobs are being executed?
Are additional unit tests run specifically for free-thread python? Or this just produces the .whl file without running tests?

The existing set of tests is ran for those new wheels, except on Windows where the tests are not run pending pywin32 availability for free-threading python (see the comment in pyproject.toml). There are no new specific tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Python 3.13t (free-threading) wheel
2 participants